Remove plugins from export set (backport #3227) #3241
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Remove plugins from export set Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * move more plugins to different export set Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * run pre-commit Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * remove plugins from moveit_kinematics export Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> * do not link base interface to plugin in kinematics Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> --------- Signed-off-by: Paul Gesel <paul.gesel@picknik.ai> Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> (cherry picked from commit b5eb4de) # Conflicts: # moveit_core/CMakeLists.txt # moveit_kinematics/CMakeLists.txt # moveit_kinematics/cached_ik_kinematics_plugin/CMakeLists.txt # moveit_ros/move_group/CMakeLists.txt
|
Cherry-pick of b5eb4de has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@pac48 Would you have time to look at how this PR would be backported to Humble / if it makes sense at all? Looking to cut a Humble release soon since there have been quite a few bugfixes lately, and it would be good to have this in. |
|
@pac48 -- thanks for your PR to help with this challenging conflict resolution! I could not have done this myself. I additionally ended up having to remove some of the libraries that did not exist in Humble, namely In addition, I had to bring in a few other fixes from main to make linking happy. These were likely fixed at some point after the divergence of humble/main, but never needed to be backported until now. |
| install( | ||
| TARGETS | ||
| collision_detector_bullet_plugin | ||
| collision_detector_fcl_plugin |
There was a problem hiding this comment.
For some reason, collision_detector_fcl_plugin was actually not in the previous list of targets to install -- but it builds fine.
@henningkayser do you maybe know if there was something specific with Humble where we shouldn't be building it?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3241 +/- ##
==========================================
+ Coverage 51.40% 51.40% +0.01%
==========================================
Files 382 384 +2
Lines 31899 31904 +5
==========================================
+ Hits 16394 16398 +4
- Misses 15505 15506 +1 ☔ View full report in Codecov by Sentry. |
|
If someone knows why the IKfast + clang-tidy checks only are failing consistently on Pilz tests after these changes, would appreciate the help... |
sea-bass
force-pushed
the
mergify/bp/humble/pr-3227
branch
from
6b698da to
d0b5635
Compare
sea-bass
force-pushed
the
mergify/bp/humble/pr-3227
branch
2 times, most recently
from
2ab36d5 to
788e95d
Compare
|
I don't see something obvious why PILZ throws ... Should we just disable this test in Humble or just not backport this change? |
Leaning towards not backporting this change... |
|
punting on this effort ✌🏻 |
Description
Plugins that are intended to be loaded by classloader or pluginlib should not be in export sets that
ament_export_targetsis called on. This can cause plugins to fail to load.This is an automatic backport of pull request #3227 done by Mergify.